RNS-Things/rns-page-node
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor-pagenode-logic #1

Merged
Ivan merged 5 commits from refactor-pagenode-logic into main 2025-12-02 17:26:06 +00:00
Conversation 0 Commits 5 Files Changed 2 +154 -50
Ivan commented 2025-12-02 17:26:00 +00:00
Owner
Copy Link
No description provided.
Ivan added 5 commits 2025-12-02 17:26:00 +00:00
Refactor PageNode class to improve page and file registration logic 71bd49bd7d 
- Consolidated page and file scanning methods to return lists of served pages and files.
- Improved error handling in file reading operations.
- Updated the announce loop to use a more efficient waiting mechanism.
- Improved command-line argument handling for log level configuration.
Add docstrings to PageNode methods for improved clarity 1571b315b2
Refactor _scan_pages method and enhance file reading logic in PageNode class d4099fb9a2 
- Updated docstring for _scan_pages to clarify exclusion of .allowed files.
- Improved file reading logic to handle script detection and content retrieval more efficiently.
- Refined error handling during the announce process to catch specific exceptions.
add windows runner test 4ec44900cf
Refactor path handling in PageNode class for improved reliability
Some checks failed
Docker Build Test / build (3.11) (pull_request) Successful in 1m9s
Details
Docker Build Test / build (3.10) (pull_request) Successful in 1m12s
Details
Docker Build Test / build (3.12) (pull_request) Successful in 1m8s
Details
Docker Build Test / build (3.13) (pull_request) Failing after 2s
Details
Build and Publish Docker Image / build (pull_request) Failing after 2s
Details
Run Tests / test (windows-latest, 3.10) (pull_request) Has been cancelled
Details
Run Tests / test (windows-latest, 3.11) (pull_request) Has been cancelled
Details
Run Tests / test (windows-latest, 3.12) (pull_request) Has been cancelled
Details
Run Tests / test (windows-latest, 3.13) (pull_request) Has been cancelled
Details
Run Tests / test (windows-latest, 3.9) (pull_request) Has been cancelled
Details
Docker Build Test / build (3.9) (pull_request) Failing after 2s
Details
Run Tests / test (ubuntu-latest, 3.10) (pull_request) Failing after 2s
Details
Run Tests / test (ubuntu-latest, 3.11) (pull_request) Failing after 2s
Details
Run Tests / test (ubuntu-latest, 3.12) (pull_request) Failing after 1s
Details
Run Tests / test (ubuntu-latest, 3.13) (pull_request) Failing after 1s
Details
Run Tests / test (ubuntu-latest, 3.9) (pull_request) Failing after 2s
Details
ccf954681b 
- Updated path resolution for pages and files to use `resolve()` method, ensuring absolute paths are handled correctly.
- Enhanced relative path calculation using `relative_to()` to improve robustness against invalid paths.
- Adjusted request path formatting to include a leading slash for consistency.
Ivan merged commit d6228d6d63 into main 2025-12-02 17:26:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Ivan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RNS-Things/rns-page-node#1
Delete Branch "refactor-pagenode-logic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?