Mirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv.git synced 2025-12-28 05:33:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

configure: uniform the defines to #define HAVE_xxx (0|1)

Browse Source 
The configure followed 5 different convetions of defines because the next guy
always wanted to introduce a new better way to uniform it[1]. For an
hypothetic feature 'hurr' you could have had:

  * #define HAVE_HURR 1   / #undef HAVE_DURR
  * #define HAVE_HURR     / #undef HAVE_DURR
  * #define CONFIG_HURR 1 / #undef CONFIG_DURR
  * #define HAVE_HURR 1   / #define HAVE_DURR 0
  * #define CONFIG_HURR 1 / #define CONFIG_DURR 0

All is now uniform and uses:
  * #define HAVE_HURR 1
  * #define HAVE_DURR 0

We like definining to 0 as opposed to `undef` bcause it can help spot typos
and is very helpful when doing big reorganizations in the code.

[1]: http://xkcd.com/927/ related
This commit is contained in:
Stefano Pigozzi
2013-07-16 13:28:28 +02:00
parent 891a2a1f47
commit 37388ebb0e
52 changed files with 528 additions and 500 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
stream/ai_oss.c
View File

@@ -26,10 +26,10 @@
#include <errno.h>
#include <sys/ioctl.h>
#ifdef HAVE_SYS_SOUNDCARD_H
#if HAVE_SYS_SOUNDCARD_H
#include <sys/soundcard.h>
#else
#ifdef HAVE_SOUNDCARD_H
#if HAVE_SOUNDCARD_H
#include <soundcard.h>
#else
#include <linux/soundcard.h>