Mirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv.git synced 2025-12-28 05:33:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

parse_configfile: check quote termination properly

Browse Source 
This is some terrible code; I blame MPlayer legacy.

Found by Coverity.
This commit is contained in:
wm4
2014-11-21 10:08:20 +01:00
parent 75f38dcc9a
commit 863a050258
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
options/parse_configfile.c
View File

@@ -156,6 +156,13 @@ int m_config_parse_config_file(m_config_t *config, const char *conffile,
c = line[line_pos]; c = line[line_pos];
++line_pos; ++line_pos;
for (param_pos = 0; line[line_pos] != c; /* NOTHING */) { for (param_pos = 0; line[line_pos] != c; /* NOTHING */) {
if (!line[line_pos]) {
PRINT_LINENUM;
MP_ERR(config, "unterminated quotes\n");
ret = -1;
errors++;
goto nextline;
}
param[param_pos++] = line[line_pos++]; param[param_pos++] = line[line_pos++];
if (param_pos >= MAX_PARAM_LEN) { if (param_pos >= MAX_PARAM_LEN) {
PRINT_LINENUM; PRINT_LINENUM;