mirror of
https://github.com/mpv-player/mpv.git
synced 2025-12-22 10:57:08 +00:00
a58e9e596b
This reverts commite9c43258b8. yt-dlp implemented its own parsing to extract chapters from the descriptions of videos without chapter markers in the player over 3 years ago in https://github.com/yt-dlp/yt-dlp/commit/0fe51254 (the PR is even inspired by mpv). Actually it was present even earlier in youtube-dl but was removed for unknown reasons in67299f23d8. So we can remove our parsing code, as it is dead code that never runs if yt-dlp's JSON already contains chapters. And it seems that such videos without chapter markers are rare or non-existing by now anyway - we can't find any. https://www.youtube.com/watch?v=1v_4dL8l8pQ is linked from the yt-dlp PR with the above commit, but now yt-dlp returns the Key moments as chapters, so it can't be used for testing. Our parsing was actually worse than yt-dlp's, because #16085 added an option to disable it to fix the misdetection reported in #16081, but yt-dlp correctly returns no chapter for that video (https://www.youtube.com/watch?v=1v_4dL8l8pQ). So this code branch was only running for misdetections, and by removing it that option is not needed.