From 438f514e76922a54eb1a1e31e7e93ef2c7367ce9 Mon Sep 17 00:00:00 2001 From: Georges-Antoine Assi Date: Tue, 28 Oct 2025 11:38:57 -0400 Subject: [PATCH] fix tests --- .trunk/trunk.yaml | 18 +++++++++--------- .../filesystem/test_resources_handler.py | 12 +++--------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index e8b87cc3f..fcf6ad39a 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -7,7 +7,7 @@ cli: plugins: sources: - id: trunk - ref: v1.7.2 + ref: v1.7.3 uri: https://github.com/trunk-io/plugins # Many linters and tools depend on runtimes - configure them here. (https://docs.trunk.io/runtimes) runtimes: @@ -25,25 +25,25 @@ lint: - dotenv-linter@3.3.0 - hadolint@2.14.0 - markdownlint@0.45.0 - - eslint@9.36.0 - - actionlint@1.7.7 + - eslint@9.38.0 + - actionlint@1.7.8 - bandit@1.8.6 - black@25.9.0 - - checkov@3.2.473 + - checkov@3.2.488 - git-diff-check - - isort@6.0.1 + - isort@7.0.0 - mypy@1.18.2 - - osv-scanner@2.2.2 + - osv-scanner@2.2.3 - prettier@3.6.2: packages: - "@trivago/prettier-plugin-sort-imports@5.2.2" - "@vue/compiler-sfc@3.5.22" - - ruff@0.13.2 + - ruff@0.14.2 - shellcheck@0.11.0 - shfmt@3.6.0 - taplo@0.10.0 - - trivy@0.67.0 - - trufflehog@3.90.8 + - trivy@0.67.2 + - trufflehog@3.90.12 - yamllint@1.37.1 ignore: - linters: [ALL] diff --git a/backend/tests/handler/filesystem/test_resources_handler.py b/backend/tests/handler/filesystem/test_resources_handler.py index aed93103b..b7bdd8f2f 100644 --- a/backend/tests/handler/filesystem/test_resources_handler.py +++ b/backend/tests/handler/filesystem/test_resources_handler.py @@ -259,10 +259,10 @@ class TestFSResourcesHandler: ): """Test get_rom_screenshots with no URLs""" result = await handler.get_rom_screenshots(rom, True, None) - assert result == [] + assert result == rom.path_screenshots result = await handler.get_rom_screenshots(rom, True, []) - assert result == [] + assert result == rom.path_screenshots @pytest.mark.asyncio async def test_get_rom_screenshots_with_urls( @@ -298,17 +298,11 @@ class TestFSResourcesHandler: result = handler._get_manual_path(rom) assert result is None - @pytest.mark.asyncio - async def test_get_manual_no_rom(self, handler: FSResourcesHandler): - """Test get_manual with no ROM""" - result = await handler.get_manual(None, False, "http://example.com/manual.pdf") - assert result is None - @pytest.mark.asyncio async def test_get_manual_no_url(self, handler: FSResourcesHandler, rom: Rom): """Test get_manual with no URL""" result = await handler.get_manual(rom, False, None) - assert result is None + assert result is rom.path_manual @pytest.mark.asyncio async def test_get_manual_with_url_no_overwrite(