Mirrors/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2025-12-23 19:00:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

changes from bot review

Browse Source
This commit is contained in:
Georges-Antoine Assi
2025-09-21 20:51:30 -04:00
parent d7a31d638c
commit e349ce6104
6 changed files with 29 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backend/config/config_manager.py
View File

@@ -398,19 +398,19 @@ class ConfigManager:
sys.exit(3)
if not isinstance(self.config.SCAN_METADATA_PRIORITY, list):
log.critical("Invalid config.yml: scan.metadata.priority must be a list")
log.critical("Invalid config.yml: scan.priority.metadata must be a list")
sys.exit(3)
if not isinstance(self.config.SCAN_ARTWORK_PRIORITY, list):
log.critical("Invalid config.yml: scan.artwork.priority must be a list")
log.critical("Invalid config.yml: scan.priority.artwork must be a list")
sys.exit(3)
if not isinstance(self.config.SCAN_REGION_PRIORITY, list):
log.critical("Invalid config.yml: scan.region.priority must be a list")
log.critical("Invalid config.yml: scan.priority.region must be a list")
sys.exit(3)
if not isinstance(self.config.SCAN_LANGUAGE_PRIORITY, list):
log.critical("Invalid config.yml: scan.language.priority must be a list")
log.critical("Invalid config.yml: scan.priority.language must be a list")
sys.exit(3)
def get_config(self) -> Config:

2
backend/handler/database/roms_handler.py
View File

@@ -510,8 +510,8 @@ class DBRomsHandler(DBBaseHandler):
),
_create_metadata_id_case(
"romm",
base_subquery.c.platform_id,
base_subquery.c.id,
base_subquery.c.platform_id,
),
),
order_by=[

28
backend/handler/metadata/ss_handler.py
View File

@@ -28,33 +28,17 @@ SS_DEV_PASSWORD: Final = base64.b64decode("eFRKd29PRmpPUUc=").decode()
def get_preferred_regions() -> list[str]:
"""Get preferred regions from config, merged with defaults"""
"""Get preferred regions from config"""
config = cm.get_config()
default_regions = ["us", "wor", "ss", "eu", "jp"]
ordered_regions = [
region for region in config.SCAN_REGION_PRIORITY if region in default_regions
]
remaining_regions = [
region
for region in default_regions
if region not in config.SCAN_REGION_PRIORITY
]
return ordered_regions + remaining_regions
return list(
dict.fromkeys(config.SCAN_REGION_PRIORITY + ["us", "wor", "ss", "eu", "jp"])
)
def get_preferred_languages() -> list[str]:
"""Get preferred languages from config, merged with defaults"""
"""Get preferred languages from config"""
config = cm.get_config()
default_languages = ["en", "fr"]
ordered_languages = [
lang for lang in config.SCAN_LANGUAGE_PRIORITY if lang in default_languages
]
remaining_languages = [
lang for lang in default_languages if lang not in config.SCAN_LANGUAGE_PRIORITY
]
return ordered_languages + remaining_languages
return list(dict.fromkeys(config.SCAN_LANGUAGE_PRIORITY + ["en", "fr"]))
PS1_SS_ID: Final = 57

5
backend/handler/scan_handler.py
View File

@@ -57,7 +57,7 @@ class MetadataSource(enum.StrEnum):
IGDB = "igdb" # IGDB
MOBY = "moby" # MobyGames
SS = "ss" # Screenscraper
RA = "ra" # RetroAchivements
RA = "ra" # RetroAchievements
LB = "lb" # Launchbox
HASHEOUS = "hasheous" # Hasheous
TGDB = "tgdb" # TheGamesDB
@@ -633,6 +633,7 @@ async def scan_rom(
priority_ordered = get_priority_ordered_metadata_sources(
available_sources, "metadata"
)
# Reverse priority order to apply highest priority last
for source_name in reversed(priority_ordered):
rom_attrs.update({**metadata_handlers[source_name]})
@@ -640,6 +641,8 @@ async def scan_rom(
priority_ordered_artwork = get_priority_ordered_metadata_sources(
available_sources, "artwork"
)
# Reverse priority order to apply highest priority last
for source_name in reversed(priority_ordered_artwork):
handler_data = metadata_handlers[source_name]
if handler_data.get("url_cover"):

4
examples/config.example.yml
View File

@@ -55,7 +55,7 @@ filesystem: {} # { roms_folder: 'roms' } For example if your folder structure is
# - "igdb" # IGDB
# - "moby" # MobyGames
# - "ss" # Screenscraper
# - "ra" # RetroAchivements
# - "ra" # RetroAchievements
# - "lb" # Launchbox
# - "hasheous" # Hasheous
# - "flashpoint" # Flashpoint Project
@@ -64,7 +64,7 @@ filesystem: {} # { roms_folder: 'roms' } For example if your folder structure is
# - "igdb" # IGDB
# - "moby" # MobyGames
# - "ss" # Screenscraper
# - "ra" # RetroAchivements
# - "ra" # RetroAchievements
# - "lb" # Launchbox
# - "hasheous" # Hasheous
# - "flashpoint" # Flashpoint Project

15
frontend/src/components/Details/Info/GameInfo.vue
View File

@@ -91,10 +91,19 @@ const coverImageSource = computed(() => {
if (hostname === "images.igdb.com") return "IGDB";
if (hostname === "screenscraper.fr") return "ScreenScraper";
if (hostname === "cdn.mobygames.com") return "MobyGames";
if (hostname === "retroachievements.org") return "RetroAchievements";
if (hostname === "cdn.mobygames.com" || hostname === "cdn2.mobygames.com")
return "MobyGames";
if (
hostname === "retroachievements.org" ||
hostname === "media.retroachievements.org"
)
return "RetroAchievements";
if (hostname === "images.launchbox-app.com") return "LaunchBox";
if (hostname === "cdn2.steamgriddb.com") return "SteamGridDB";
if (
hostname === "cdn.steamgriddb.com" ||
hostname === "cdn2.steamgriddb.com"
)
return "SteamGridDB";
if (hostname === "hasheous.org") return "Hasheous";
if (hostname === "infinity.unstable.life") return "Flashpoint";
if (hostname === "howlongtobeat.com") return "HowLongToBeat";