fix: add security comments to clarify handling of non-critical errors in ratchet file operations
Some checks failed
Go Build Multi-Platform / build (arm, freebsd) (push) Failing after 35s
Go Build Multi-Platform / build (arm, linux) (push) Failing after 39s
Go Build Multi-Platform / build (arm, windows) (push) Failing after 38s
Go Build Multi-Platform / build (arm64, freebsd) (push) Failing after 30s
Go Build Multi-Platform / build (amd64, darwin) (push) Failing after 29s
Go Build Multi-Platform / build (amd64, freebsd) (push) Failing after 33s
Go Build Multi-Platform / build (amd64, windows) (push) Failing after 32s
Go Build Multi-Platform / build (amd64, linux) (push) Failing after 35s
Go Build Multi-Platform / build (arm64, darwin) (push) Failing after 36s
Go Build Multi-Platform / build (arm64, linux) (push) Failing after 36s
Go Build Multi-Platform / build (arm64, windows) (push) Failing after 34s
Run Gosec / tests (push) Failing after 58s
Go Test Multi-Platform / Test (macos-latest, amd64) (push) Has been cancelled
Go Test Multi-Platform / Test (windows-latest, amd64) (push) Has been cancelled
Go Test Multi-Platform / Test (ubuntu-latest, arm64) (push) Successful in 46s
Go Build Multi-Platform / Create Release (push) Has been skipped
Go Test Multi-Platform / Test (ubuntu-latest, amd64) (push) Successful in 1m28s
Go Revive Lint / lint (push) Successful in 55s
Go Test Multi-Platform / Test (macos-latest, arm64) (push) Has been cancelled
Some checks failed
Go Build Multi-Platform / build (arm, freebsd) (push) Failing after 35s
Go Build Multi-Platform / build (arm, linux) (push) Failing after 39s
Go Build Multi-Platform / build (arm, windows) (push) Failing after 38s
Go Build Multi-Platform / build (arm64, freebsd) (push) Failing after 30s
Go Build Multi-Platform / build (amd64, darwin) (push) Failing after 29s
Go Build Multi-Platform / build (amd64, freebsd) (push) Failing after 33s
Go Build Multi-Platform / build (amd64, windows) (push) Failing after 32s
Go Build Multi-Platform / build (amd64, linux) (push) Failing after 35s
Go Build Multi-Platform / build (arm64, darwin) (push) Failing after 36s
Go Build Multi-Platform / build (arm64, linux) (push) Failing after 36s
Go Build Multi-Platform / build (arm64, windows) (push) Failing after 34s
Run Gosec / tests (push) Failing after 58s
Go Test Multi-Platform / Test (macos-latest, amd64) (push) Has been cancelled
Go Test Multi-Platform / Test (windows-latest, amd64) (push) Has been cancelled
Go Test Multi-Platform / Test (ubuntu-latest, arm64) (push) Successful in 46s
Go Build Multi-Platform / Create Release (push) Has been skipped
Go Test Multi-Platform / Test (ubuntu-latest, amd64) (push) Successful in 1m28s
Go Revive Lint / lint (push) Successful in 55s
Go Test Multi-Platform / Test (macos-latest, arm64) (push) Has been cancelled
This commit is contained in:
@@ -544,14 +544,18 @@ func (i *Identity) saveRatchets(path string) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if _, err := file.Write(finalData); err != nil {
|
if _, err := file.Write(finalData); err != nil {
|
||||||
|
// #nosec G104 - Error already being handled, cleanup errors are non-critical
|
||||||
file.Close()
|
file.Close()
|
||||||
|
// #nosec G104 - Error already being handled, cleanup errors are non-critical
|
||||||
os.Remove(tempPath)
|
os.Remove(tempPath)
|
||||||
return fmt.Errorf("failed to write ratchet data: %w", err)
|
return fmt.Errorf("failed to write ratchet data: %w", err)
|
||||||
}
|
}
|
||||||
|
// #nosec G104 - File is being closed after successful write, error is non-critical
|
||||||
file.Close()
|
file.Close()
|
||||||
|
|
||||||
// Atomic rename
|
// Atomic rename
|
||||||
if err := os.Rename(tempPath, path); err != nil {
|
if err := os.Rename(tempPath, path); err != nil {
|
||||||
|
// #nosec G104 - Error already being handled, cleanup errors are non-critical
|
||||||
os.Remove(tempPath)
|
os.Remove(tempPath)
|
||||||
return fmt.Errorf("failed to rename ratchet file: %w", err)
|
return fmt.Errorf("failed to rename ratchet file: %w", err)
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user