Networks/Reticulum-Go
2
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

refactor(interfaces): remove Send method from UDPInterface and streamline packet processing

Browse Source
This commit is contained in:
ivan
2026-01-02 17:48:43 -06:00
parent e508f63b83
commit 25e04b1b80
1 changed files with 1 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
pkg/interfaces/udp.go
View File

@@ -87,30 +87,6 @@ func (ui *UDPInterface) Detach() {
}) })
} }
func (ui *UDPInterface) Send(data []byte, addr string) error {
debug.Log(debug.DEBUG_ALL, "UDP interface sending bytes", "name", ui.Name, "bytes", len(data))
if !ui.IsEnabled() {
return fmt.Errorf("interface not enabled")
}
if ui.targetAddr == nil {
return fmt.Errorf("no target address configured")
}
ui.Mutex.Lock()
ui.TxBytes += uint64(len(data))
ui.Mutex.Unlock()
_, err := ui.conn.WriteTo(data, ui.targetAddr)
if err != nil {
debug.Log(debug.DEBUG_CRITICAL, "UDP interface write failed", "name", ui.Name, "error", err)
} else {
debug.Log(debug.DEBUG_ALL, "UDP interface sent bytes successfully", "name", ui.Name, "bytes", len(data))
}
return err
}
func (ui *UDPInterface) SetPacketCallback(callback common.PacketCallback) { func (ui *UDPInterface) SetPacketCallback(callback common.PacketCallback) {
ui.Mutex.Lock() ui.Mutex.Lock()
defer ui.Mutex.Unlock() defer ui.Mutex.Unlock()
@@ -143,10 +119,6 @@ func (ui *UDPInterface) ProcessOutgoing(data []byte) error {
return fmt.Errorf("UDP write failed: %v", err) return fmt.Errorf("UDP write failed: %v", err)
} }
ui.Mutex.Lock()
ui.TxBytes += uint64(len(data))
ui.Mutex.Unlock()
return nil return nil
} }
@@ -269,20 +241,14 @@ func (ui *UDPInterface) readLoop() {
} }
ui.Mutex.Lock() ui.Mutex.Lock()
// #nosec G115 - Network read sizes are always positive and within safe range
ui.RxBytes += uint64(n)
// Auto-discover target address from first packet if not set // Auto-discover target address from first packet if not set
if ui.targetAddr == nil { if ui.targetAddr == nil {
debug.Log(debug.DEBUG_ALL, "UDP interface discovered peer", "name", ui.Name, "peer", remoteAddr.String()) debug.Log(debug.DEBUG_ALL, "UDP interface discovered peer", "name", ui.Name, "peer", remoteAddr.String())
ui.targetAddr = remoteAddr ui.targetAddr = remoteAddr
} }
callback := ui.packetCallback
ui.Mutex.Unlock() ui.Mutex.Unlock()
if callback != nil { ui.ProcessIncoming(buffer[:n])
callback(buffer[:n], ui)
}
} }
} }