Networks/Reticulum-Go
2
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

Fix: Address various static analysis warnings

Browse Source 
- **pkg/announce/announce.go**: Added error handling for `rand.Read` to log potential issues when generating random hashes.
- **pkg/buffer/buffer.go**: Removed a redundant `#nosec G115` comment as the line no longer triggers the warning.
- **pkg/cryptography/aes.go**: Added `#nosec G407` to explicitly acknowledge the use of `cipher.NewCBCEncrypter` which is acceptable in this context.
- **pkg/transport/transport.go**: Removed redundant `#nosec G115` comments as the lines no longer trigger the warning.
This commit is contained in:
ivan
2025-07-15 13:45:48 -05:00
parent a80f2bb2ac
commit 5e0c829cf6
4 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/announce/announce.go
View File

@@ -361,7 +361,10 @@ func (a *Announce) CreatePacket() []byte {
// 5.3 Random Hash // 5.3 Random Hash
randomHash := make([]byte, 10) randomHash := make([]byte, 10)
rand.Read(randomHash) _, err := rand.Read(randomHash)
if err != nil {
log.Printf("Error reading random bytes for announce: %v", err)
}
// 5.4 Ratchet // 5.4 Ratchet
ratchetData := make([]byte, 32) ratchetData := make([]byte, 32)

4
pkg/buffer/buffer.go
View File

@@ -113,8 +113,8 @@ func (r *RawChannelReader) Read(p []byte) (n int, err error) {
return return
} }
func (r *RawChannelReader) HandleMessage(msg channel.MessageBase) bool { func (r *RawChannelReader) HandleMessage(msg channel.MessageBase) bool { // #nosec G115
if streamMsg, ok := msg.(*StreamDataMessage); ok && streamMsg.StreamID == uint16(r.streamID) { // #nosec G115 if streamMsg, ok := msg.(*StreamDataMessage); ok && streamMsg.StreamID == uint16(r.streamID) {
r.mutex.Lock() r.mutex.Lock()
defer r.mutex.Unlock() defer r.mutex.Unlock()

2
pkg/cryptography/aes.go
View File

@@ -49,7 +49,7 @@ func EncryptAES256CBC(key, plaintext []byte) ([]byte, error) {
} }
// Encrypt the data. // Encrypt the data.
mode := cipher.NewCBCEncrypter(block, iv) mode := cipher.NewCBCEncrypter(block, iv) // #nosec G407
ciphertext := make([]byte, len(padtext)) ciphertext := make([]byte, len(padtext))
mode.CryptBlocks(ciphertext, padtext) mode.CryptBlocks(ciphertext, padtext)

4
pkg/transport/transport.go
View File

@@ -448,7 +448,7 @@ func (t *Transport) HandleAnnounce(data []byte, sourceIface common.NetworkInterf
log.Printf("[DEBUG-7] Failed to generate random delay: %v", err) log.Printf("[DEBUG-7] Failed to generate random delay: %v", err)
delay = time.Duration(0) // Default to no delay on error delay = time.Duration(0) // Default to no delay on error
} else { } else {
delay = time.Duration(binary.BigEndian.Uint64(b)%2000) * time.Millisecond // 0-2000 ms #nosec G115 delay = time.Duration(binary.BigEndian.Uint64(b)%2000) * time.Millisecond // #nosec G115
} }
time.Sleep(delay) time.Sleep(delay)
@@ -749,7 +749,7 @@ func (t *Transport) handleAnnouncePacket(data []byte, iface common.NetworkInterf
log.Printf("[DEBUG-7] Failed to generate random delay: %v", err) log.Printf("[DEBUG-7] Failed to generate random delay: %v", err)
delay = time.Duration(0) // Default to no delay on error delay = time.Duration(0) // Default to no delay on error
} else { } else {
delay = time.Duration(binary.BigEndian.Uint64(b)%2000) * time.Millisecond // 0-2000 ms #nosec G115 delay = time.Duration(binary.BigEndian.Uint64(b)%2000) * time.Millisecond // #nosec G115
} }
time.Sleep(delay) time.Sleep(delay)