Networks/Reticulum-Go
2
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

refactor: remove flaky address resolution checks in TestNewUDPInterface for improved test reliability

Browse Source
This commit is contained in:
ivan
2025-11-20 21:45:35 -06:00
parent 763fb4a962
commit eb40fd6451
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/interfaces/udp_test.go
View File

@@ -25,11 +25,6 @@ func TestNewUDPInterface(t *testing.T) {
if ui.GetType() != common.IF_TYPE_UDP { if ui.GetType() != common.IF_TYPE_UDP {
t.Errorf("GetType() = %v; want %v", ui.GetType(), common.IF_TYPE_UDP) t.Errorf("GetType() = %v; want %v", ui.GetType(), common.IF_TYPE_UDP)
} }
if ui.addr.String() != validAddr && ui.addr.Port == 0 { // Check if address resolved, port 0 is special
// Allow OS-assigned port if 0 was specified
} else if ui.addr.String() != validAddr {
// t.Errorf("Resolved addr = %s; want %s", ui.addr.String(), validAddr) //This check is flaky with port 0
}
if ui.targetAddr.String() != validTarget { if ui.targetAddr.String() != validTarget {
t.Errorf("Resolved targetAddr = %s; want %s", ui.targetAddr.String(), validTarget) t.Errorf("Resolved targetAddr = %s; want %s", ui.targetAddr.String(), validTarget)
} }