Networks/Reticulum-Go
2
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

security: use net.JoinHostPort instead of fmt.Sprintf
Some checks failed
Benchmark GC Performance / benchmark (push) Successful in 1m19s
Details
Run Gosec / tests (push) Successful in 48s
Details
Go Revive Lint / lint (push) Successful in 34s
Details
Go Build Multi-Platform / build (amd64, darwin) (push) Failing after 31s
Details
Go Build Multi-Platform / build (amd64, windows) (push) Failing after 34s
Details
Go Build Multi-Platform / build (arm, freebsd) (push) Failing after 29s
Details
Go Build Multi-Platform / build (arm, linux) (push) Failing after 27s
Details
Go Build Multi-Platform / Create Release (push) Has been skipped
Details
Go Test Multi-Platform / Test (ubuntu-latest, arm64) (push) Successful in 48s
Details
Go Test Multi-Platform / Test (ubuntu-latest, amd64) (push) Successful in 1m28s
Details
Go Build Multi-Platform / build (amd64, freebsd) (push) Failing after 27s
Details
Go Build Multi-Platform / build (amd64, linux) (push) Failing after 27s
Details
Go Build Multi-Platform / build (arm, windows) (push) Failing after 27s
Details
Go Build Multi-Platform / build (arm64, darwin) (push) Failing after 27s
Details
Go Build Multi-Platform / build (arm64, freebsd) (push) Failing after 27s
Details
Performance Monitor / performance-monitor (push) Successful in 2m40s
Details
Go Build Multi-Platform / build (arm64, windows) (push) Failing after 25s
Details
Go Build Multi-Platform / build (arm64, linux) (push) Failing after 27s
Details
Go Test Multi-Platform / Test (macos-latest, amd64) (push) Has been cancelled
Details
Go Test Multi-Platform / Test (windows-latest, amd64) (push) Has been cancelled
Details
Go Test Multi-Platform / Test (macos-latest, arm64) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
ivan
2025-11-09 00:05:36 -06:00
parent 22fc5093db
commit f097bb3241
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/interfaces/tcp.go
View File

@@ -333,7 +333,7 @@ func (tc *TCPClientInterface) reconnect() {
// Log reconnection attempt // Log reconnection attempt
fmt.Printf("Failed to reconnect to %s (attempt %d/%d): %v\n", fmt.Printf("Failed to reconnect to %s (attempt %d/%d): %v\n",
addr, retries+1, tc.maxReconnectTries, err) net.JoinHostPort(tc.targetAddr, fmt.Sprintf("%d", tc.targetPort)), retries+1, tc.maxReconnectTries, err)
// Wait with exponential backoff // Wait with exponential backoff
time.Sleep(backoff) time.Sleep(backoff)
@@ -354,7 +354,7 @@ func (tc *TCPClientInterface) reconnect() {
// If we've exhausted all retries, perform final teardown // If we've exhausted all retries, perform final teardown
tc.teardown() tc.teardown()
fmt.Printf("Failed to reconnect to %s after %d attempts\n", fmt.Printf("Failed to reconnect to %s after %d attempts\n",
fmt.Sprintf("%s:%d", tc.targetAddr, tc.targetPort), tc.maxReconnectTries) net.JoinHostPort(tc.targetAddr, fmt.Sprintf("%d", tc.targetPort)), tc.maxReconnectTries)
} }
func (tc *TCPClientInterface) Enable() { func (tc *TCPClientInterface) Enable() {
@@ -562,7 +562,7 @@ func (ts *TCPServerInterface) Start() error {
ts.mutex.Lock() ts.mutex.Lock()
defer ts.mutex.Unlock() defer ts.mutex.Unlock()
addr := fmt.Sprintf("%s:%d", ts.bindAddr, ts.bindPort) addr := net.JoinHostPort(ts.bindAddr, fmt.Sprintf("%d", ts.bindPort))
listener, err := net.Listen("tcp", addr) listener, err := net.Listen("tcp", addr)
if err != nil { if err != nil {
return fmt.Errorf("failed to start TCP server: %w", err) return fmt.Errorf("failed to start TCP server: %w", err)