From d97676ad27819691ad2fc64f65a791e3815f76f8 Mon Sep 17 00:00:00 2001 From: Sudo-Ivan Date: Fri, 5 Dec 2025 23:19:43 -0600 Subject: [PATCH] refactor: replace inline artifact renaming with script call - Updated the Makefile to utilize `rename_legacy_artifacts.sh` for renaming legacy artifacts in the `build-appimage-legacy` and `build-exe-legacy` targets, enhancing maintainability and clarity. --- Makefile | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index fe7d637..56d174b 100644 --- a/Makefile +++ b/Makefile @@ -48,23 +48,16 @@ dist: build-appimage electron-legacy: $(NPM) install --no-save electron@$(LEGACY_ELECTRON_VERSION) +# Legacy targets intended for manual/local builds; CI uses workflow jobs. build-appimage-legacy: build electron-legacy $(NPM) run electron-postinstall $(NPM) run dist -- --linux AppImage - @set -e; for f in dist/*-linux.AppImage dist/*-linux.deb; do \ - [ -e "$$f" ] || continue; \ - dir=$$(dirname "$$f"); base=$$(basename "$$f"); ext=$${base##*.}; name=$${base%.$$ext}; \ - mv "$$f" "$$dir/$${name}-legacy.$$ext"; \ - done + ./scripts/rename_legacy_artifacts.sh build-exe-legacy: build electron-legacy $(NPM) run electron-postinstall $(NPM) run dist -- --win portable - @set -e; for f in dist/*-win-installer.exe dist/*-win-portable.exe; do \ - [ -e "$$f" ] || continue; \ - dir=$$(dirname "$$f"); base=$$(basename "$$f"); ext=$${base##*.}; name=$${base%.$$ext}; \ - mv "$$f" "$$dir/$${name}-legacy.$$ext"; \ - done + ./scripts/rename_legacy_artifacts.sh clean: rm -rf node_modules