Enhance build configuration for macOS and update artifact naming #22

2025-12-01T18:39:07Z

Sudo-Ivan commented

2025-12-01 18:39:07 +00:00

(Migrated from github.com)

Added new distribution scripts for macOS ARM64 and universal builds in package.json.
Updated macOS target configuration to support universal architecture.
Modified GitHub Actions workflow to use macOS 14 and adjusted artifact naming for macOS DMG files.

Summary by CodeRabbit

Chores
- Upgraded macOS CI runner to macOS 14 and added universal macOS (Intel + Apple Silicon) plus an arm64 build variant.
- Added explicit macOS distribution scripts and artifact naming that includes architecture; introduced a universal mac build.
- Enabled dynamic per-platform build selection so Windows, macOS, and Linux use appropriate distribution scripts.
- Stabilized CI artifact upload/download by pinning action references and using a matrix-driven build flow.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

- Added new distribution scripts for macOS ARM64 and universal builds in package.json. - Updated macOS target configuration to support universal architecture. - Modified GitHub Actions workflow to use macOS 14 and adjusted artifact naming for macOS DMG files.  ## Summary by CodeRabbit * **Chores** * Upgraded macOS CI runner to macOS 14 and added universal macOS (Intel + Apple Silicon) plus an arm64 build variant. * Added explicit macOS distribution scripts and artifact naming that includes architecture; introduced a universal mac build. * Enabled dynamic per-platform build selection so Windows, macOS, and Linux use appropriate distribution scripts. * Stabilized CI artifact upload/download by pinning action references and using a matrix-driven build flow. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

coderabbitai[bot] commented

2025-12-01 18:39:16 +00:00

(Migrated from github.com)

Walkthrough

CI workflow pins artifact actions to commit hashes, upgrades macOS runner to macos-14, and drives platform builds via a matrix dist_script (including dist:mac-arm64 and dist:mac-universal). package.json adds mac dist scripts, sets mac target to universal, and embeds arch in artifact names.

Changes

Cohort / File(s)	Summary
Workflow configuration `.github/workflows/build.yml`	Pinned frontend/artifact actions to specific commit hashes; upgraded macOS runner to `macos-14`; added `matrix.dist_script` entries for Windows/Linux/mac; renamed build step to "Build Electron App (Universal)"; build step runs `npm run ${{ matrix.dist_script }}`; artifact patterns updated to `dist/-mac-.dmg`; conditional steps adjusted to use matrix-driven scripts.
Build & package configuration `package.json`	Added `dist:mac-arm64` and `dist:mac-universal` npm scripts; changed mac `target` from `"dmg"` to `{ "target": "dmg", "arch": ["universal"] }`; updated `artifactName` to `ReticulumMeshChat-v${version}-mac-${arch}.${ext}`; added `x64ArchFiles` entry.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions runner (matrix)
    participant Actions as GH Actions (artifact download/upload)
    participant NPM as npm (matrix dist_script)
    participant EB as electron-builder
    participant Art as Artifact storage

    GH->>Actions: checkout + setup (pinned actions)
    GH->>Actions: download frontend artifacts (pinned commit)
    Actions-->>GH: provide frontend artifacts
    GH->>NPM: run npm run ${{ matrix.dist_script }}
    NPM->>EB: invoke electron-builder with platform/arch (universal/x64/arm64)
    EB-->>NPM: produce build artifacts (dist/* or dist/*-mac-*.dmg)
    GH->>Actions: upload build artifacts (pinned commit)
    Actions-->>Art: store artifacts

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Check action commit hashes and artifact upload/download steps
Verify matrix -> dist_script mappings and conditional step logic
Validate electron-builder mac universal config and artifactName pattern
Confirm macOS 14 runner compatibility

Poem

🐰 I hopped through YAML and package cheer,
ARM and Intel now build so near,
macOS fourteen opens the door,
Artifacts stamped with arch — ready to soar,
A tiny hop, a universal roar! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Enhance build configuration for macOS and update artifact naming' accurately summarizes the main changes: macOS build configuration enhancements and artifact naming updates in both package.json and GitHub Actions workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch universal-mac-build

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 365531be9b and f2ab1ad067.

📒 Files selected for processing (1)

package.json (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build Desktop (mac)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

## Walkthrough CI workflow pins artifact actions to commit hashes, upgrades macOS runner to macos-14, and drives platform builds via a matrix `dist_script` (including `dist:mac-arm64` and `dist:mac-universal`). package.json adds mac dist scripts, sets mac target to universal, and embeds arch in artifact names. ## Changes | Cohort / File(s) | Summary | |---|---| | **Workflow configuration**<br>`.github/workflows/build.yml` | Pinned frontend/artifact actions to specific commit hashes; upgraded macOS runner to `macos-14`; added `matrix.dist_script` entries for Windows/Linux/mac; renamed build step to "Build Electron App (Universal)"; build step runs `npm run ${{ matrix.dist_script }}`; artifact patterns updated to `dist/*-mac-*.dmg`; conditional steps adjusted to use matrix-driven scripts. | | **Build & package configuration**<br>`package.json` | Added `dist:mac-arm64` and `dist:mac-universal` npm scripts; changed mac `target` from `"dmg"` to `{ "target": "dmg", "arch": ["universal"] }`; updated `artifactName` to `ReticulumMeshChat-v${version}-mac-${arch}.${ext}`; added `x64ArchFiles` entry. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant GH as GitHub Actions runner (matrix) participant Actions as GH Actions (artifact download/upload) participant NPM as npm (matrix dist_script) participant EB as electron-builder participant Art as Artifact storage GH->>Actions: checkout + setup (pinned actions) GH->>Actions: download frontend artifacts (pinned commit) Actions-->>GH: provide frontend artifacts GH->>NPM: run npm run ${{ matrix.dist_script }} NPM->>EB: invoke electron-builder with platform/arch (universal/x64/arm64) EB-->>NPM: produce build artifacts (dist/* or dist/*-mac-*.dmg) GH->>Actions: upload build artifacts (pinned commit) Actions-->>Art: store artifacts ``` ## Estimated code review effort 🎯 2 (Simple) | ⏱️ ~10 minutes - Check action commit hashes and artifact upload/download steps - Verify matrix -> `dist_script` mappings and conditional step logic - Validate `electron-builder` mac universal config and artifactName pattern - Confirm macOS 14 runner compatibility ## Poem > 🐰 I hopped through YAML and package cheer, > ARM and Intel now build so near, > macOS fourteen opens the door, > Artifacts stamped with arch — ready to soar, > A tiny hop, a universal roar! 🎉   ## Pre-merge checks and finishing touches <details> <summary>✅ Passed checks (3 passed)</summary> | Check name | Status | Explanation | | :----------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title 'Enhance build configuration for macOS and update artifact naming' accurately summarizes the main changes: macOS build configuration enhancements and artifact naming updates in both package.json and GitHub Actions workflow. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | </details>   <details> <summary>✨ Finishing touches</summary> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `universal-mac-build` </details> </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 365531be9bcc54af74eb1a2625a9a510e45b7611 and f2ab1ad0670f68492e52f53ad1fde0509ce075c4. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `package.json` (2 hunks) </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * package.json </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary> * GitHub Check: Build Desktop (mac) </details> </details>  --- Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=Sudo-Ivan/reticulum-meshchatX&utm_content=22)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

deepsource-io[bot] commented

2025-12-01 18:39:17 +00:00

(Migrated from github.com)

Here's the code health analysis summary for commits d841999..f2ab1ad. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success		View Check ↗
Docker	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

<div><p>Here's the code health analysis summary for commits <code>d841999..f2ab1ad</code>. <a href="https://app.deepsource.com/gh/Sudo-Ivan/reticulum-meshchatX/run/e6cd7ae5-e542-4763-b795-a52446c429cf/">View details on DeepSource</a> ↗.</p><h3>Analysis Summary</h3><table><thead><tr><th>Analyzer</th><th>Status</th><th>Summary</th><th>Link</th></tr></thead><tbody><tr><td><img src="https://static.deepsource.com/analyzer_logos/python.svg" alt="DeepSource Python Logo" width="16px" height="16px"/><strong>Python</strong></td><td><span>✅ </span><span>Success</span></td><td></td><td><a href="https://app.deepsource.com/gh/Sudo-Ivan/reticulum-meshchatX/run/e6cd7ae5-e542-4763-b795-a52446c429cf/python/">View Check</a> ↗</td></tr><tr><td><img src="https://static.deepsource.com/analyzer_logos/docker.svg" alt="DeepSource Docker Logo" width="16px" height="16px"/><strong>Docker</strong></td><td><span>✅ </span><span>Success</span></td><td></td><td><a href="https://app.deepsource.com/gh/Sudo-Ivan/reticulum-meshchatX/run/e6cd7ae5-e542-4763-b795-a52446c429cf/docker/">View Check</a> ↗</td></tr></tbody></table><hr/><blockquote><div>💡 If you’re a repository administrator, you can configure the quality gates from the <a href="https://app.deepsource.com/gh/Sudo-Ivan/reticulum-meshchatX/settings/reporting">settings</a>.</div></blockquote></div>

coderabbitai[bot] (Migrated from github.com) reviewed 2025-12-01 18:43:14 +00:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8419990b1 and a74a6869ea.

📒 Files selected for processing (2)

.github/workflows/build.yml (2 hunks)
package.json (2 hunks)

🔇 Additional comments (4)

.github/workflows/build.yml (2)

83-83: macOS runner upgrade from 13 to 14 is reasonable.

Upgrading to macOS 14 improves build consistency and security. Ensure your local development environment is also using a compatible macOS version to avoid environment mismatches.

176-180: No issues found - the workflow correctly uses dist-prebuilt for all platforms.

The frontend is intentionally pre-built in a separate build_frontend job and downloaded as an artifact before the Electron build step runs (line 149-156). The dist-prebuilt script is designed to skip frontend building since the frontend artifact is already available, making it appropriate for all platforms (windows, macos, linux). The step name "(Universal)" accurately reflects that it runs on all matrix platforms without platform-specific conditionals.

package.json (2)

15-15: dist-prebuilt intentionally skips frontend build and is correctly used in the workflow.

The dist-prebuilt script skips the frontend build step (npm run build-frontend), unlike the standard dist script. This is intentional: the GitHub Actions workflow explicitly builds the frontend in a separate build_frontend job (line 34–66), uploads it as an artifact, and then the build_desktop job (which depends on build_frontend completing) downloads that artifact before running npm run dist-prebuilt (line 180). The frontend artifact is guaranteed to be available before the Electron build step, and the same artifact is used for all platform builds (Windows, macOS, Linux), so no platform-specific frontend issues exist. The workflow design is sound.

41-46: macOS target configuration syntax is supported by electron-builder.

The nested target object with the arch array is a valid TargetConfiguration format supported by electron-builder. The "universal" architecture value for macOS is properly configured. No changes needed to this configuration.

**Actionable comments posted: 3** <details> <summary>📜 Review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between d8419990b1a1423553974bf55b046f65210b9689 and a74a6869ea052fa169fdb8603f456e7fd0cdab98. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `.github/workflows/build.yml` (2 hunks) * `package.json` (2 hunks) </details> <details> <summary>🔇 Additional comments (4)</summary><blockquote> <details> <summary>.github/workflows/build.yml (2)</summary><blockquote> `83-83`: **macOS runner upgrade from 13 to 14 is reasonable.** Upgrading to macOS 14 improves build consistency and security. Ensure your local development environment is also using a compatible macOS version to avoid environment mismatches. --- `176-180`: **No issues found - the workflow correctly uses dist-prebuilt for all platforms.** The frontend is intentionally pre-built in a separate `build_frontend` job and downloaded as an artifact before the Electron build step runs (line 149-156). The `dist-prebuilt` script is designed to skip frontend building since the frontend artifact is already available, making it appropriate for all platforms (windows, macos, linux). The step name "(Universal)" accurately reflects that it runs on all matrix platforms without platform-specific conditionals. </blockquote></details> <details> <summary>package.json (2)</summary><blockquote> `15-15`: **`dist-prebuilt` intentionally skips frontend build and is correctly used in the workflow.** The `dist-prebuilt` script skips the frontend build step (`npm run build-frontend`), unlike the standard `dist` script. This is intentional: the GitHub Actions workflow explicitly builds the frontend in a separate `build_frontend` job (line 34–66), uploads it as an artifact, and then the `build_desktop` job (which depends on `build_frontend` completing) downloads that artifact before running `npm run dist-prebuilt` (line 180). The frontend artifact is guaranteed to be available before the Electron build step, and the same artifact is used for all platform builds (Windows, macOS, Linux), so no platform-specific frontend issues exist. The workflow design is sound. --- `41-46`: **macOS target configuration syntax is supported by electron-builder.** The nested target object with the arch array is a valid TargetConfiguration format supported by electron-builder. The `"universal"` architecture value for macOS is properly configured. No changes needed to this configuration. </blockquote></details> </blockquote></details> </details>

.github/workflows/build.yml

						
				@@ -94,3 +96,4 @@

				            dist_script: dist-prebuilt

				    permissions:

				      contents: write

				    steps:

coderabbitai[bot] (Migrated from github.com) commented

2025-12-01 18:43:12 +00:00

⚠️ Potential issue | 🟠 Major

Artifact upload pattern may not match generated filenames with architecture suffix.

The release_artifacts pattern at line 86 was updated to dist/*-mac-*.dmg (to account for architecture), but the artifact upload at line 192 still uses the old pattern dist/*-mac.dmg. The new artifactName in package.json includes ${arch}, so generated files will be named like ReticulumMeshChat-v2.41.0-mac-universal.dmg, which matches the wildcard pattern at line 86 but the upload step at line 192 may not capture them correctly.

Update the artifact upload pattern to include architecture:

         path: |
           dist/*-win-installer.exe
           dist/*-win-portable.exe
-          dist/*-mac.dmg
+          dist/*-mac-*.dmg
           dist/*-linux.AppImage
           dist/*-linux.deb
           python-dist/*.whl

Also applies to: 192-192

🤖 Prompt for AI Agents

.github/workflows/build.yml around lines 86 and 192: the release_artifacts
pattern was changed to include an architecture segment (`dist/*-mac-*.dmg` vs
`dist/*-mac.dmg`) but the artifact upload step still uses the old pattern and
will miss files named with `${arch}` (e.g.,
ReticulumMeshChat-v2.41.0-mac-universal.dmg); update the upload step's artifact
file pattern at line 192 to also include the architecture wildcard (e.g., change
`dist/*-mac.dmg` to `dist/*-mac-*.dmg`) and scan the file for any other
occurrences of the old pattern to make them consistent.

✅ Addressed in commits c95d2fd to d69a3e8

_⚠️ Potential issue_ | _🟠 Major_ **Artifact upload pattern may not match generated filenames with architecture suffix.** The `release_artifacts` pattern at line 86 was updated to `dist/*-mac-*.dmg` (to account for architecture), but the artifact upload at line 192 still uses the old pattern `dist/*-mac.dmg`. The new `artifactName` in package.json includes `${arch}`, so generated files will be named like `ReticulumMeshChat-v2.41.0-mac-universal.dmg`, which matches the wildcard pattern at line 86 but the upload step at line 192 may not capture them correctly. Update the artifact upload pattern to include architecture: ```diff path: | dist/*-win-installer.exe dist/*-win-portable.exe - dist/*-mac.dmg + dist/*-mac-*.dmg dist/*-linux.AppImage dist/*-linux.deb python-dist/*.whl ``` Also applies to: 192-192 <details> <summary>🤖 Prompt for AI Agents</summary> ``` .github/workflows/build.yml around lines 86 and 192: the release_artifacts pattern was changed to include an architecture segment (`dist/*-mac-*.dmg` vs `dist/*-mac.dmg`) but the artifact upload step still uses the old pattern and will miss files named with `${arch}` (e.g., ReticulumMeshChat-v2.41.0-mac-universal.dmg); update the upload step's artifact file pattern at line 192 to also include the architecture wildcard (e.g., change `dist/*-mac.dmg` to `dist/*-mac-*.dmg`) and scan the file for any other occurrences of the old pattern to make them consistent. ``` </details>  ✅ Addressed in commits c95d2fd to d69a3e8

package.json

						
				@@ -16,1 +15,4 @@

				    "dist-prebuilt": "npm run electron-postinstall && npm run build-backend && electron-builder --publish=never",

				    "dist:mac-arm64": "npm run electron-postinstall && npm run build && electron-builder --mac --arm64 --publish=never",

				    "dist:mac-universal": "npm run electron-postinstall && npm run build && electron-builder --mac --universal --publish=never"

				  },

coderabbitai[bot] (Migrated from github.com) commented

2025-12-01 18:43:12 +00:00

⚠️ Potential issue | 🟠 Major

New dist:mac-arm64 and dist:mac-universal scripts are unused by the workflow.

Three distribution scripts now exist:

dist: full build for current platform (used by legacy code)
dist-prebuilt: skips frontend, used by workflow for ALL platforms
dist:mac-arm64 & dist:mac-universal: architecture-specific, but never invoked

The workflow always calls npm run dist-prebuilt regardless of platform, so the new macOS-specific scripts with explicit architecture targets are dead code. This defeats the purpose of offering architecture-specific builds.

Either:

Update the workflow to invoke the appropriate script based on matrix platform, or
Remove the unused scripts if they're not needed.

If option 1, update .github/workflows/build.yml line 180 to:

-        run: npm run dist-prebuilt
+        run: |
+          case "${{ matrix.name }}" in
+            mac) npm run dist:mac-universal ;;
+            *) npm run dist ;;
+          esac

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In package.json around lines 15 to 17 the new scripts "dist:mac-arm64" and
"dist:mac-universal" are never used by CI because the workflow always runs "npm
run dist-prebuilt"; either remove those two architecture-specific scripts if you
don't plan to use them, or update the GitHub Actions workflow to invoke the
correct script per platform—specifically modify .github/workflows/build.yml at
line 180 to run the appropriate dist script based on the job matrix (e.g., use a
conditional or matrix variable to call npm run dist:mac-arm64 for macOS/arm64
and npm run dist:mac-universal for macOS/universal) so the architecture-specific
builds are actually executed.

✅ Addressed in commits c95d2fd to d69a3e8

_⚠️ Potential issue_ | _🟠 Major_ **New `dist:mac-arm64` and `dist:mac-universal` scripts are unused by the workflow.** Three distribution scripts now exist: - `dist`: full build for current platform (used by legacy code) - `dist-prebuilt`: skips frontend, used by workflow for ALL platforms - `dist:mac-arm64` & `dist:mac-universal`: architecture-specific, but never invoked The workflow always calls `npm run dist-prebuilt` regardless of platform, so the new macOS-specific scripts with explicit architecture targets are dead code. This defeats the purpose of offering architecture-specific builds. Either: 1. **Update the workflow** to invoke the appropriate script based on matrix platform, or 2. **Remove the unused scripts** if they're not needed. If option 1, update `.github/workflows/build.yml` line 180 to: ```diff - run: npm run dist-prebuilt + run: | + case "${{ matrix.name }}" in + mac) npm run dist:mac-universal ;; + *) npm run dist ;; + esac ``` > Committable suggestion skipped: line range outside the PR's diff. <details> <summary>🤖 Prompt for AI Agents</summary> ``` In package.json around lines 15 to 17 the new scripts "dist:mac-arm64" and "dist:mac-universal" are never used by CI because the workflow always runs "npm run dist-prebuilt"; either remove those two architecture-specific scripts if you don't plan to use them, or update the GitHub Actions workflow to invoke the correct script per platform—specifically modify .github/workflows/build.yml at line 180 to run the appropriate dist script based on the job matrix (e.g., use a conditional or matrix variable to call npm run dist:mac-arm64 for macOS/arm64 and npm run dist:mac-universal for macOS/universal) so the architecture-specific builds are actually executed. ``` </details>  ✅ Addressed in commits c95d2fd to d69a3e8

package.json

						
				@@ -36,9 +38,15 @@

				      "buildResources": "electron/build"

coderabbitai[bot] (Migrated from github.com) commented

2025-12-01 18:43:12 +00:00

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Search for hardcoded assumptions about artifact names in scripts
rg -nP 'ReticulumMeshChat.*\-mac' --type sh --type js --type json