Ren/Browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Refactor text extraction in Micron renderer for improved attribute access

Browse Source 
- Updated the text extraction logic to use public attributes instead of private ones, enhancing readability and maintainability.
- Adjusted corresponding unit tests to reflect the changes in attribute access.
This commit is contained in:
ivan
2025-09-28 18:29:25 -05:00
parent e8ee623a82
commit dc18d57547
2 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ren_browser/renderer/micron.py
View File

@@ -565,12 +565,10 @@ def render_micron(content: str, ascii_art_scale: float = 0.75) -> ft.Control:
)
text_content = ""
if hasattr(control, "_Text__spans") and control._Text__spans:
text_content = "".join(span.text for span in control._Text__spans)
elif hasattr(control, "_Control__attrs") and "text" in control._Control__attrs:
text_content = control._Control__attrs["text"][0]
elif hasattr(control, "_Control__attrs") and "value" in control._Control__attrs:
text_content = control._Control__attrs["value"][0]
if hasattr(control, "spans") and control.spans:
text_content = "".join(span.text for span in control.spans)
elif hasattr(control, "value") and control.value:
text_content = control.value
else:
text_content = ""

8
tests/unit/test_renderers.py
View File

@@ -104,8 +104,8 @@ class TestMicronRenderer:
for control in result.controls:
assert isinstance(control, ft.Text)
# Extract text from the merged control
if hasattr(control, "_Control__attrs") and "value" in control._Control__attrs:
all_text += control._Control__attrs["value"][0]
if hasattr(control, "value") and control.value:
all_text += control.value
# Should preserve the content
assert content in all_text
@@ -139,8 +139,8 @@ class TestRendererComparison:
for control in micron_result.controls:
if isinstance(control, ft.Text):
# Extract text from the merged control
if hasattr(control, "_Control__attrs") and "value" in control._Control__attrs:
micron_text += control._Control__attrs["value"][0] + "\n"
if hasattr(control, "value") and control.value:
micron_text += control.value + "\n"
# Remove trailing newline and compare
micron_text = micron_text.rstrip("\n")