Remove review-prompt and migrate the only unique BW instruction to the CLAUDE.md (#18049)

This commit is contained in:
Mick Letofsky
2025-12-18 19:19:09 +01:00
committed by GitHub
parent 799644c5aa
commit 524bd9a484
2 changed files with 3 additions and 57 deletions

View File

@@ -18,6 +18,9 @@
- **NEVER** commit secrets, credentials, or sensitive information.
- **CRITICAL**: Tailwind CSS classes MUST use the `tw-` prefix (e.g., `tw-flex`, `tw-p-4`).
- Missing prefix breaks styling completely.
- **NEVER** log decrypted data, encryption keys, or PII
- No vault data in error messages or console logs

View File

@@ -1,57 +0,0 @@
# Bitwarden Clients Repo Code Review - Careful Consideration Required
## Think Twice Before Recommending
Angular has multiple valid patterns. Before suggesting changes:
- **Consider the context** - Is this code part of an active modernization effort?
- **Check for established patterns** - Look for similar implementations in the codebase
- **Avoid premature optimization** - Don't suggest refactoring stable, working code without clear benefit
- **Respect incremental progress** - Teams may be modernizing gradually with feature flags
## Angular Modernization - Handle with Care
**Control Flow Syntax (@if, @for, @switch):**
- When you see legacy structural directives (*ngIf, *ngFor), consider whether modernization is in scope
- Do not mandate changes to stable code unless part of the PR's objective
- If suggesting modernization, acknowledge it's optional unless required by PR goals
**Standalone Components:**
- New components should be standalone whenever feasible, but do not flag existing NgModule components as issues
- Legacy patterns exist for valid reasons - consider modernization effort vs benefit
**Typed Forms:**
- Recommend typed forms for NEW form code
- Don't suggest rewriting working untyped forms unless they're being modified
## Tailwind CSS - Critical Pattern
**tw- prefix is mandatory** - This is non-negotiable and should be flagged as ❌ major finding:
- Missing tw- prefix breaks styling completely
- Check ALL Tailwind classes in modified files
## Rust SDK Adoption - Tread Carefully
When reviewing cipher operations:
- Look for breaking changes in the TypeScript → Rust boundary
- Verify error handling matches established patterns
- Don't suggest alternative SDK patterns without strong justification
## Component Library First
Before suggesting custom implementations:
- Check if Bitwarden's component library already provides the functionality
- Prefer existing components over custom Tailwind styling
- Don't add UI complexity that the component library already solves
## When in Doubt
- **Ask questions** (💭) rather than making definitive recommendations
- **Flag for human review** (⚠️) if you're uncertain
- **Acknowledge alternatives** exist when suggesting improvements