mirror of
https://github.com/mpv-player/mpv.git
synced 2025-12-28 05:33:14 +00:00
e23e4c7c60
With --idle --force-window, or when started from the bundle, the cocoa code dropped the first frame. This resulted in a black frame on start sometimes. The reason was that the live resizing/redrawing code was invoked, which simply set skip_swap_buffer to false, blocking redrawing whatever was going to be rendered next. Normally this is done so that the following works: 1. vo_opengl draw a frame, releases GL lock 2. live resizing kicks in, redraw the frame 3. vo_opengl wants to call SwapBuffers, drawing a stale buffer overwritten by the live resizing code This is solved by setting skip_swap_buffer in 2., and querying it in 3. Fix this by resetting the skip_swap_buffer at a known good point: when vo_opengl starts drawing a new frame. The start_frame function returns bool, so that it can be merged with is_active in a following commit.
48 lines
1.6 KiB
C
48 lines
1.6 KiB
C
/*
|
|
* Cocoa OpenGL Backend
|
|
*
|
|
* This file is part of mpv.
|
|
*
|
|
* mpv is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* mpv is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with mpv. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef MPLAYER_COCOA_COMMON_H
|
|
#define MPLAYER_COCOA_COMMON_H
|
|
|
|
#include "vo.h"
|
|
|
|
struct vo_cocoa_state;
|
|
|
|
int vo_cocoa_init(struct vo *vo);
|
|
void vo_cocoa_uninit(struct vo *vo);
|
|
|
|
int vo_cocoa_config_window(struct vo *vo, uint32_t flags, void *gl_ctx);
|
|
|
|
void vo_cocoa_set_current_context(struct vo *vo, bool current);
|
|
bool vo_cocoa_start_frame(struct vo *vo);
|
|
void vo_cocoa_swap_buffers(struct vo *vo);
|
|
int vo_cocoa_check_events(struct vo *vo);
|
|
int vo_cocoa_control(struct vo *vo, int *events, int request, void *arg);
|
|
|
|
void vo_cocoa_register_resize_callback(struct vo *vo,
|
|
void (*cb)(struct vo *vo, int w, int h));
|
|
|
|
void vo_cocoa_register_gl_clear_callback(struct vo *vo, void *ctx,
|
|
void (*cb)(void *ctx));
|
|
|
|
void vo_cocoa_create_nsgl_ctx(struct vo *vo, void *ctx);
|
|
void vo_cocoa_release_nsgl_ctx(struct vo *vo);
|
|
|
|
#endif /* MPLAYER_COCOA_COMMON_H */
|